experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #46229 from tensorflow/cherrypick_350241208

Browse Source 
No longer compile with `-march=native`.
This commit is contained in:
Mihai Maruseac 2021-01-19 09:26:48 -08:00 committed by GitHub
commit 863cb7a45d
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
configure.py
View File

@ -526,7 +526,12 @@ def set_cc_opt_flags(environ_cp):
elif is_windows(): elif is_windows():
default_cc_opt_flags = '/arch:AVX' default_cc_opt_flags = '/arch:AVX'
else: else:
default_cc_opt_flags = '-Wno-sign-compare' # TODO(mihaimaruseac): Was '-march=native -Wno-sign-compare' # On all other platforms, no longer use `-march=native` as this can result
# in instructions that are too modern being generated. Users that want
# maximum performance should compile TF in their environment and can pass
# `-march=native` there.
# See https://github.com/tensorflow/tensorflow/issues/45744 and duplicates
default_cc_opt_flags = '-Wno-sign-compare'
question = ('Please specify optimization flags to use during compilation when' question = ('Please specify optimization flags to use during compilation when'
' bazel option "--config=opt" is specified [Default is %s]: ' ' bazel option "--config=opt" is specified [Default is %s]: '
) % default_cc_opt_flags ) % default_cc_opt_flags
@ -534,11 +539,6 @@ def set_cc_opt_flags(environ_cp):
question, default_cc_opt_flags) question, default_cc_opt_flags)
for opt in cc_opt_flags.split(): for opt in cc_opt_flags.split():
write_to_bazelrc('build:opt --copt=%s' % opt) write_to_bazelrc('build:opt --copt=%s' % opt)
# It should be safe on the same build host.
# TODO(mihaimaruseac): we removed `-march=native` above
#if not is_ppc64le() and not is_windows():
# write_to_bazelrc('build:opt --host_copt=-march=native')
write_to_bazelrc('build:opt --host_copt=%s' % opt)
write_to_bazelrc('build:opt --define with_default_optimizations=true') write_to_bazelrc('build:opt --define with_default_optimizations=true')