experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix build error on Windows caused by potential int32 overflow.

Browse Source 
PiperOrigin-RevId: 253411612
This commit is contained in:
Frank Chen 2019-06-15 16:53:26 -07:00 committed by TensorFlower Gardener
parent 7321424357
commit 8211365f9e
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tensorflow/core/kernels/data/experimental/snapshot_dataset_op.cc
View File

@ -46,6 +46,9 @@ namespace {
enum SnapshotMode { READER = 0, WRITER = 1, PASSTHROUGH = 2 };
// Defaults to 10 GiB per shard.
const int64 kDefaultShardSizeBytes = 10L * 1024 * 1024 * 1024;
const size_t kHeaderSize = sizeof(uint64);
const char kSnapshotFilename[] = "snapshot.metadata";
@ -255,6 +258,13 @@ class SnapshotDatasetOp : public UnaryDatasetOpKernel {
OP_REQUIRES_OK(ctx, ctx->GetAttr("pending_snapshot_expiry_seconds",
&pending_snapshot_expiry_seconds_));
if (shard_size_bytes_ == -1) shard_size_bytes_ = kDefaultShardSizeBytes;
// Default to 1 day expiry for snapshots.
if (pending_snapshot_expiry_seconds_ == -1) {
pending_snapshot_expiry_seconds_ = 86400;
}
OP_REQUIRES(
ctx,
compression_ == io::compression::kNone ||

5
tensorflow/python/data/experimental/ops/snapshot.py
View File

@ -45,11 +45,10 @@ class _SnapshotDataset(dataset_ops.UnaryUnchangedStructureDataset):
self._writer_path_prefix = (
writer_path_prefix if writer_path_prefix is not None else "")
self._shard_size_bytes = (
shard_size_bytes
if shard_size_bytes is not None else 10 * 1024 * 1024 * 1024)
shard_size_bytes if shard_size_bytes is not None else -1)
self._pending_snapshot_expiry_seconds = (
pending_snapshot_expiry_seconds
if pending_snapshot_expiry_seconds is not None else 86400)
if pending_snapshot_expiry_seconds is not None else -1)
self._input_dataset = input_dataset
self._path = ops.convert_to_tensor(path, dtype=dtypes.string, name="path")