From 80b3b4fa9f8ab6565a91273dc38aeabda0258bb6 Mon Sep 17 00:00:00 2001 From: Alex Zinenko Date: Mon, 15 Jun 2020 10:47:31 -0700 Subject: [PATCH] [XLA] LHLO-to-Ploop: explicitly construct ValueRange when building scf::ParallelOp The builder API is about to change in LLVM, which would lead to ambiguity in overload resolution in these cases. Proactively fix the issue by constructing ValueRange of steps explicitly before it is passed to the builder function. PiperOrigin-RevId: 316497983 Change-Id: Ibb5dfe006071ab9513634c9613f43ce60a0efd22 --- .../mlir/xla/transforms/lhlo_legalize_to_parallel_loops.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tensorflow/compiler/mlir/xla/transforms/lhlo_legalize_to_parallel_loops.cc b/tensorflow/compiler/mlir/xla/transforms/lhlo_legalize_to_parallel_loops.cc index 734a75a4307..b3112d49103 100644 --- a/tensorflow/compiler/mlir/xla/transforms/lhlo_legalize_to_parallel_loops.cc +++ b/tensorflow/compiler/mlir/xla/transforms/lhlo_legalize_to_parallel_loops.cc @@ -261,7 +261,7 @@ class ReduceOpConverter : public OpConversionPattern { rewriter->setInsertionPointToStart(outer.getBody()); } scf::ParallelOp inner = rewriter->create( - loc, reduce_lower, reduce_upper, reduce_step, init_value); + loc, reduce_lower, reduce_upper, reduce_step, ValueRange(init_value)); Value reduction_result = *inner.getResults().begin(); SmallVector out_indices; @@ -406,7 +406,7 @@ class ReduceWindowOpConverter rewriter->create(loc, window_dim.getSExtValue())); } auto window_loop = rewriter->create( - loc, window_lower, window_upper, window_step, init_value); + loc, window_lower, window_upper, window_step, ValueRange(init_value)); Value reduction_result = *window_loop.getResults().begin(); auto output_ivs = output_loop.getInductionVars();