From 7f1653325a47ac9c943d083de57c037111e1f742 Mon Sep 17 00:00:00 2001 From: "A. Unique TensorFlower" Date: Mon, 17 Aug 2020 04:33:59 -0700 Subject: [PATCH] Update documentation about the possible values of support status. PiperOrigin-RevId: 326997320 Change-Id: I4d29b268c40dbe16b1704bf43745981631a35dfc --- .../acceleration/compatibility/devicedb-sample.json | 6 +----- .../acceleration/compatibility/devicedb_test.cc | 2 +- .../experimental/acceleration/compatibility/variables.h | 6 ++---- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/tensorflow/lite/experimental/acceleration/compatibility/devicedb-sample.json b/tensorflow/lite/experimental/acceleration/compatibility/devicedb-sample.json index 61f9e1210f9..444b4b52d9b 100644 --- a/tensorflow/lite/experimental/acceleration/compatibility/devicedb-sample.json +++ b/tensorflow/lite/experimental/acceleration/compatibility/devicedb-sample.json @@ -100,10 +100,6 @@ { "variable": "tflite.gpu.status", "value": "SUPPORTED" - }, - { - "variable": "tflite.gpu.opencl_status", - "value": "SUPPORTED" } ] } @@ -150,7 +146,7 @@ "value": "j8y18lte", "derived_properties": [ { - "variable": "tflite.gpu.opencl_status", + "variable": "tflite.gpu.status", "value": "SUPPORTED" } ] diff --git a/tensorflow/lite/experimental/acceleration/compatibility/devicedb_test.cc b/tensorflow/lite/experimental/acceleration/compatibility/devicedb_test.cc index c9c6ff831e5..5cd500c66af 100644 --- a/tensorflow/lite/experimental/acceleration/compatibility/devicedb_test.cc +++ b/tensorflow/lite/experimental/acceleration/compatibility/devicedb_test.cc @@ -115,7 +115,7 @@ TEST_F(DeviceDbTest, StatusLookupWithDevice) { variables[kDeviceModel] = "sm_j810m"; variables[kDeviceName] = "j8y18lte"; UpdateVariablesFromDatabase(&variables, *device_db_); - EXPECT_EQ(variables[gpu::kOpenCLStatus], gpu::kStatusSupported); + EXPECT_EQ(variables[gpu::kStatus], gpu::kStatusSupported); } TEST_F(DeviceDbTest, StatusLookupBasedOnDerivedProperties) { diff --git a/tensorflow/lite/experimental/acceleration/compatibility/variables.h b/tensorflow/lite/experimental/acceleration/compatibility/variables.h index 3904dbdb486..4e0b864c037 100644 --- a/tensorflow/lite/experimental/acceleration/compatibility/variables.h +++ b/tensorflow/lite/experimental/acceleration/compatibility/variables.h @@ -71,12 +71,10 @@ namespace gpu { // GPU-delegate derived properties. // Whether the GPU delegate works in general. -// ("UNSET", "UNKNOWN", "SUPPORTED", "UNSUPPORTED"). +// Possible values are ("", "SUPPORTED", "UNSUPPORTED"). An empty value for +// this field means that the device is unsupported. constexpr char kStatus[] = "tflite.gpu.status"; -// Whether OpenCL should be allowed. Possible values are the SupportStatus enums -// ("UNSET", "UNKNOWN", "SUPPORTED", "UNSUPPORTED"). -constexpr char kOpenCLStatus[] = "tflite.gpu.opencl_status"; constexpr char kStatusSupported[] = "SUPPORTED"; constexpr char kStatusUnsupported[] = "UNSUPPORTED"; } // namespace gpu