address comments

This commit is contained in:
Zhoulong Jiang 2020-11-18 10:28:12 +00:00
parent e87611188f
commit 77cf1eba91
3 changed files with 2 additions and 6 deletions

View File

@ -777,9 +777,7 @@ TF_Library* TF_LoadPluggableDeviceLibrary(const char* library_filename,
} else { } else {
status->status = status->status =
env->LoadDynamicLibrary(library_filename, &lib_handle->lib_handle); env->LoadDynamicLibrary(library_filename, &lib_handle->lib_handle);
if (status->status.ok()) { if (!status->status.ok()) {
// Init PluggableDevice Plugin
} else {
delete lib_handle; delete lib_handle;
return nullptr; return nullptr;
} }

View File

@ -170,7 +170,6 @@ class DeviceBase {
return device_thread_pool_; return device_thread_pool_;
} }
// Does not take ownership. // Does not take ownership.
void set_eigen_cpu_device(Eigen::ThreadPoolDevice* d); void set_eigen_cpu_device(Eigen::ThreadPoolDevice* d);
@ -204,7 +203,6 @@ class DeviceBase {
virtual const Eigen::ThreadPoolDevice* eigen_cpu_device(); virtual const Eigen::ThreadPoolDevice* eigen_cpu_device();
// Caller owns the return value. The OpKernelContext calls this even // Caller owns the return value. The OpKernelContext calls this even
// for devices that do not implement an eigen_gpu_device. Overridden // for devices that do not implement an eigen_gpu_device. Overridden
// by GPU devices to return a derived type. // by GPU devices to return a derived type.

View File

@ -159,7 +159,7 @@ def load_library(library_location):
library_location) library_location)
def load_pluggable_device_library(library_location): def load_pluggable_device_library(library_location):
"""Loads a Tensorflow PluggableDevice plugin. """Loads a TensorFlow PluggableDevice plugin.
"library_location" can be a path to a specific shared object, or a folder. "library_location" can be a path to a specific shared object, or a folder.
If it is a folder, all shared objects will be loaded. when the library is If it is a folder, all shared objects will be loaded. when the library is
loaded, devices/kernels registered in the library via StreamExecutor C API loaded, devices/kernels registered in the library via StreamExecutor C API