From 7628059dbf3644b9073245dea5c52f9f05faba81 Mon Sep 17 00:00:00 2001 From: Trent Lo Date: Mon, 12 Aug 2019 14:44:12 -0700 Subject: [PATCH] [XLA] Fix build break in OSS by adding missing dependencies. 1. "compiler/xla/types.h" is needed for uint16 in "compiler/xla/bit_cast.h". 2. "gmock/gmock-more-matchers.h" is needed for IsEmpty(). 3. Add some more dependencies. --- tensorflow/compiler/xla/bit_cast.h | 1 + tensorflow/compiler/xla/test.h | 1 + tensorflow/compiler/xla/tests/BUILD | 2 ++ tensorflow/compiler/xla/tests/collective_ops_test.cc | 1 + 4 files changed, 5 insertions(+) diff --git a/tensorflow/compiler/xla/bit_cast.h b/tensorflow/compiler/xla/bit_cast.h index c9edd7417eb..90e9a5c25dd 100644 --- a/tensorflow/compiler/xla/bit_cast.h +++ b/tensorflow/compiler/xla/bit_cast.h @@ -28,6 +28,7 @@ limitations under the License. #include "absl/base/casts.h" #include "third_party/eigen3/Eigen/Core" +#include "tensorflow/compiler/xla/types.h" #include "tensorflow/core/lib/bfloat16/bfloat16.h" #include "tensorflow/core/platform/types.h" diff --git a/tensorflow/compiler/xla/test.h b/tensorflow/compiler/xla/test.h index a657554dc2f..c20c1341541 100644 --- a/tensorflow/compiler/xla/test.h +++ b/tensorflow/compiler/xla/test.h @@ -41,6 +41,7 @@ limitations under the License. #else #include #include +#include #endif #include "tensorflow/core/platform/test.h" diff --git a/tensorflow/compiler/xla/tests/BUILD b/tensorflow/compiler/xla/tests/BUILD index 7f0eb42a135..ae0d70610be 100644 --- a/tensorflow/compiler/xla/tests/BUILD +++ b/tensorflow/compiler/xla/tests/BUILD @@ -1650,6 +1650,7 @@ xla_test( name = "fmax_fmin_test", srcs = ["fmax_fmin_test.cc"], deps = [ + ":test_macros_header", "//tensorflow/compiler/xla/client:local_client", "//tensorflow/compiler/xla/client:xla_builder", "//tensorflow/compiler/xla/client:xla_computation", @@ -1889,6 +1890,7 @@ xla_test( "//tensorflow/compiler/xla/service:hlo", "//tensorflow/compiler/xla/service:hlo_parser", "//tensorflow/compiler/xla/service:hlo_runner", + "//tensorflow/compiler/xla/service/gpu:nccl_all_reduce_thunk", "//tensorflow/compiler/xla/tests:client_library_test_base", "//tensorflow/compiler/xla/tests:hlo_test_base", "//tensorflow/compiler/xla/tests:literal_test_util", diff --git a/tensorflow/compiler/xla/tests/collective_ops_test.cc b/tensorflow/compiler/xla/tests/collective_ops_test.cc index b8439ee0fdd..efa7448f191 100644 --- a/tensorflow/compiler/xla/tests/collective_ops_test.cc +++ b/tensorflow/compiler/xla/tests/collective_ops_test.cc @@ -13,6 +13,7 @@ See the License for the specific language governing permissions and limitations under the License. ==============================================================================*/ +#include "absl/strings/str_replace.h" #include "absl/types/span.h" #include "tensorflow/compiler/xla/literal.h" #include "tensorflow/compiler/xla/service/gpu/nccl_all_reduce_thunk.h"