From 75178dbafbb9353b804663e16a548b87affb186b Mon Sep 17 00:00:00 2001 From: Zhoulong Jiang Date: Sun, 6 Dec 2020 15:17:44 +0000 Subject: [PATCH] address comments --- tensorflow/c/c_api_experimental.h | 10 +++++----- tensorflow/python/eager/context.py | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tensorflow/c/c_api_experimental.h b/tensorflow/c/c_api_experimental.h index 4ab56e8adb8..493590f7247 100644 --- a/tensorflow/c/c_api_experimental.h +++ b/tensorflow/c/c_api_experimental.h @@ -305,18 +305,18 @@ TF_ImportGraphDefOptionsSetValidateColocationConstraints( TF_ImportGraphDefOptions* opts, unsigned char enable); // Load the library specified by library_filename and register the pluggable -// device and related kernels present in that library. This function should work -// on all the platforms supported by TensorFlow, apart from embedded/mobile -// platforms. +// device and related kernels present in that library. This function is not +// supported on embedded on mobile and embedded platforms and will fail if +// called. // // Pass "library_filename" to a platform-specific mechanism for dynamically // loading a library. The rules for determining the exact location of the // library are platform-specific and are not documented here. // -// On success, place OK in status and return the newly created library handle. +// On success, returns the newly created library handle and places OK in status. // The caller owns the library handle. // -// On failure, return nullptr and places an error status in status. +// On failure, returns nullptr and places an error status in status. TF_CAPI_EXPORT extern TF_Library* TF_LoadPluggableDeviceLibrary( const char* library_filename, TF_Status* status); diff --git a/tensorflow/python/eager/context.py b/tensorflow/python/eager/context.py index a034e9efe8c..70fdcfe51ed 100644 --- a/tensorflow/python/eager/context.py +++ b/tensorflow/python/eager/context.py @@ -1243,10 +1243,10 @@ class Context(object): self._thread_local_data.invoking_op_callbacks = value def _initialize_physical_devices(self, reinitialize=False): - """Get local devices visible to the system. + """Gets local devices visible to the system. Args: - reinitialize: This flag will reinitialize self._physical_devices so that + reinitialize: If True, reinitializes self._physical_devices so that dynamic registered devices will also be visible to the python front-end. """ # We lazy initialize self._physical_devices since we do not want to do this @@ -1272,7 +1272,7 @@ class Context(object): self._import_config() def reinitialize_physical_devices(self): - """Get local devices visible to the system.""" + """Gets local devices visible to the system.""" # Reinitialize the physical device list after registering # the pluggable device. self._initialize_physical_devices(True)