experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make TF_DeleteKernelBuilder not crash on nullptr.

Browse Source 
After this change, TF_DeleteKernelBuilder will comply with the
conventions established in c_api.h, namely that *Delete* functions are
safe with nullptr parameters.

PiperOrigin-RevId: 230009727
This commit is contained in:
James Ring 2019-01-18 15:59:16 -08:00 committed by TensorFlower Gardener
parent d86e3ae608
commit 708090d489
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tensorflow/c/kernels.cc
View File

@ -48,9 +48,10 @@ TF_KernelBuilder* TF_NewKernelBuilder(
}
void TF_DeleteKernelBuilder(TF_KernelBuilder* builder) {
DCHECK_NE(builder, nullptr);
delete builder->cc_builder;
delete builder;
if (builder != nullptr) {
delete builder->cc_builder;
delete builder;
}
}
namespace tensorflow {

4
tensorflow/c/kernels_test.cc
View File

@ -224,4 +224,8 @@ TEST(TestKernel, TestInputAndOutputCount) {
}
}
TEST(TestKernel, DeleteKernelBuilderIsOkOnNull) {
TF_DeleteKernelBuilder(nullptr);
}
} // namespace tensorflow