experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[XLA] Avoid UB in absl::bitcast from Eigen::half.

Browse Source 
PiperOrigin-RevId: 219331320
This commit is contained in:
Michael Kuperstein 2018-10-30 11:09:02 -07:00 committed by TensorFlower Gardener
parent 507c566376
commit 6b8e08a932
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tensorflow/compiler/xla/literal_comparison.cc
View File

@ -34,16 +34,22 @@ namespace xla {
namespace literal_comparison { namespace literal_comparison {
namespace { namespace {
// Since Eigen::half doesn't satisfy the absl::bit_cast contract, we need to be
// able to transparently access the raw 16-bit value contained within.
template <typename T>
T GetRawValue(T val) {
return val;
}
uint16 GetRawValue(Eigen::half val) { return val.x; }
// Helper function for comparing a floating point type, FloatT, bitwise equal // Helper function for comparing a floating point type, FloatT, bitwise equal
// between the left-hand-side and right-hand-side, by bit-casting to UnsignedT // between the left-hand-side and right-hand-side, by bit-casting to UnsignedT
// -- on miscompare, a nice error message is given in the AssertionFailure. // -- on miscompare, a nice error message is given in the AssertionFailure.
template <typename FloatT, typename UnsignedT> template <typename FloatT, typename UnsignedT>
Status CompareFloatsBitwiseEqual(FloatT lhs, FloatT rhs, Status CompareFloatsBitwiseEqual(FloatT lhs, FloatT rhs,
absl::Span<const int64> multi_index) { absl::Span<const int64> multi_index) {
// TODO(b/118627822): These are unsafe bit_casts because Eigen::Half is not auto ulhs = absl::bit_cast<UnsignedT>(GetRawValue(lhs));
// trivially copyable. auto urhs = absl::bit_cast<UnsignedT>(GetRawValue(rhs));
auto ulhs = absl::bit_cast<UnsignedT>(lhs);
auto urhs = absl::bit_cast<UnsignedT>(rhs);
auto lhs_double = static_cast<double>(lhs); auto lhs_double = static_cast<double>(lhs);
auto rhs_double = static_cast<double>(rhs); auto rhs_double = static_cast<double>(rhs);
if (ulhs != urhs) { if (ulhs != urhs) {