experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Disable some flaky tests

Browse Source 
This CL disables some reduction vectorization tests because they have a couple of problems:

  1. The test tests different things depending on the GPU present on the machine
     that the test is run on.  This makes test failures non-reproducible.
  2. The test also tests the equivalent of the output of `opt -O3`.  This makes
     it difficult to root cause failures when they do happen.

I will fix the tests separately as a follow-up.

PiperOrigin-RevId: 320071954
Change-Id: I3e3b6df2d23c48fa18fc4ebd23035919c1a4592d
This commit is contained in:
Sanjoy Das 2020-07-07 15:20:54 -07:00 committed by TensorFlower Gardener
parent 216ac563c7
commit 683c3eb5fc
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tensorflow/compiler/xla/service/gpu/tests/reduction_vectorization_test.cc
View File

@ -34,7 +34,7 @@ namespace {
class ReductionVectorizationTest : public GpuCodegenTest {};
TEST_F(ReductionVectorizationTest, Power2) {
TEST_F(ReductionVectorizationTest, DISABLED_Power2) {
const char* hlo_text = R"(
HloModule ReducePower2
@ -82,7 +82,7 @@ CHECK: ld.global.nc.f32
EXPECT_TRUE(RunAndCompare(hlo_text, ErrorSpec{1e-5, 1e-5}));
}
TEST_F(ReductionVectorizationTest, TileFit) {
TEST_F(ReductionVectorizationTest, DISABLED_TileFit) {
const char* hlo_text = R"(
HloModule ReduceTileFit
@ -130,7 +130,7 @@ CHECK: ld.global.nc.f32
EXPECT_TRUE(RunAndCompare(hlo_text, ErrorSpec{1e-5, 1e-5}));
}
TEST_F(ReductionVectorizationTest, EvenColumns) {
TEST_F(ReductionVectorizationTest, DISABLED_EvenColumns) {
const char* hlo_text = R"(
HloModule ReducePower2
@ -183,7 +183,7 @@ CHECK: ld.global.nc.f32
EXPECT_TRUE(RunAndCompare(hlo_text, ErrorSpec{1e-5, 1e-5}));
}
TEST_F(ReductionVectorizationTest, DisabledOddColumns) {
TEST_F(ReductionVectorizationTest, DISABLED_DisabledOddColumns) {
const char* hlo_text = R"(
HloModule ReduceTileFit
@ -212,7 +212,7 @@ CHECK-NOT: ld.global.u64
EXPECT_TRUE(RunAndCompare(hlo_text, ErrorSpec{1e-5, 1e-5}));
}
TEST_F(ReductionVectorizationTest, Exp) {
TEST_F(ReductionVectorizationTest, DISABLED_Exp) {
const char* hlo_text = R"(
HloModule DisableSin
@ -262,7 +262,7 @@ CHECK: ld.global.nc.f32
EXPECT_TRUE(RunAndCompare(hlo_text, ErrorSpec{1e-5, 1e-5}));
}
TEST_F(ReductionVectorizationTest, DisableSin) {
TEST_F(ReductionVectorizationTest, DISABLED_DisableSin) {
const char* hlo_text = R"(
HloModule DisableSin