From 64b83e87245fe48af117008c4e9ff608f7276015 Mon Sep 17 00:00:00 2001
From: Andy Ly <lyandy@google.com>
Date: Fri, 24 Apr 2020 15:29:50 -0700
Subject: [PATCH] Update tf.MatrixBandPart, tf.ResourceApplyAdagradV2 and
 tf.ResourceApplyMomentum summaries and descriptions to match between
 TensorFlow op definitions and TensorFlow MLIR ODS.

PiperOrigin-RevId: 308338605
Change-Id: I31c240b984ac4f1f873379910682d935ad50ac07
---
 tensorflow/compiler/mlir/tensorflow/ir/tf_generated_ops.td    | 3 +--
 tensorflow/core/api_def/base_api/api_def_MatrixBandPart.pbtxt | 4 +---
 .../api_def/base_api/api_def_ResourceApplyAdagradV2.pbtxt     | 2 +-
 .../core/api_def/base_api/api_def_ResourceApplyMomentum.pbtxt | 4 ++--
 4 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_generated_ops.td b/tensorflow/compiler/mlir/tensorflow/ir/tf_generated_ops.td
index 1cc7e75fcaa..d14be1cfd0f 100644
--- a/tensorflow/compiler/mlir/tensorflow/ir/tf_generated_ops.td
+++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_generated_ops.td
@@ -3979,8 +3979,7 @@ cublas.
 
 def TF_MatrixBandPartOp : TF_Op<"MatrixBandPart", [AllTypesMatch<["input", "band"]>, NoSideEffect]> {
   let summary = [{
-Copy a tensor setting everything outside a central band in each innermost matrix
-to zero.
+Copy a tensor setting everything outside a central band in each innermost matrix to zero.
   }];
 
   let description = [{
diff --git a/tensorflow/core/api_def/base_api/api_def_MatrixBandPart.pbtxt b/tensorflow/core/api_def/base_api/api_def_MatrixBandPart.pbtxt
index eaf3d28437b..9d83972a8d9 100644
--- a/tensorflow/core/api_def/base_api/api_def_MatrixBandPart.pbtxt
+++ b/tensorflow/core/api_def/base_api/api_def_MatrixBandPart.pbtxt
@@ -26,10 +26,8 @@ END
 Rank `k` tensor of the same shape as input. The extracted banded tensor.
 END
   }
-  summary: "Copy a tensor setting everything outside a central band in each innermost matrix"
+  summary: "Copy a tensor setting everything outside a central band in each innermost matrix to zero."
   description: <<END
-to zero.
-
 The `band` part is computed as follows:
 Assume `input` has `k` dimensions `[I, J, K, ..., M, N]`, then the output is a
 tensor with the same shape where
diff --git a/tensorflow/core/api_def/base_api/api_def_ResourceApplyAdagradV2.pbtxt b/tensorflow/core/api_def/base_api/api_def_ResourceApplyAdagradV2.pbtxt
index d99d4184a2c..9eb6a48b40f 100644
--- a/tensorflow/core/api_def/base_api/api_def_ResourceApplyAdagradV2.pbtxt
+++ b/tensorflow/core/api_def/base_api/api_def_ResourceApplyAdagradV2.pbtxt
@@ -42,6 +42,6 @@ END
   summary: "Update \'*var\' according to the adagrad scheme."
   description: <<END
 accum += grad * grad
-var -= lr * grad * (1 / sqrt(accum))
+var -= lr * grad * (1 / (sqrt(accum) + epsilon))
 END
 }
diff --git a/tensorflow/core/api_def/base_api/api_def_ResourceApplyMomentum.pbtxt b/tensorflow/core/api_def/base_api/api_def_ResourceApplyMomentum.pbtxt
index d1a84a4c34b..3920cca25ad 100644
--- a/tensorflow/core/api_def/base_api/api_def_ResourceApplyMomentum.pbtxt
+++ b/tensorflow/core/api_def/base_api/api_def_ResourceApplyMomentum.pbtxt
@@ -46,9 +46,9 @@ var - lr * momentum * accum, so in the end, the var you get is actually
 var - lr * momentum * accum.
 END
   }
-  summary: "Update \'*var\' according to the momentum scheme. Set use_nesterov = True if you"
+  summary: "Update \'*var\' according to the momentum scheme."
   description: <<END
-want to use Nesterov momentum.
+Set use_nesterov = True if you want to use Nesterov momentum.
 
 accum = accum * momentum + grad
 var -= lr * accum