From 62c7ae13014e3f1734716804ea62c2f4decd2da2 Mon Sep 17 00:00:00 2001 From: Jaehong Kim Date: Thu, 26 Nov 2020 00:29:18 -0800 Subject: [PATCH] Add bug for TODO in conv and depthwise conv range check. PiperOrigin-RevId: 344377636 Change-Id: Ic955e569f9848417c643f9bc4b43cefd63fa8503 --- tensorflow/lite/kernels/internal/reference/integer_ops/conv.h | 2 +- .../kernels/internal/reference/integer_ops/depthwise_conv.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tensorflow/lite/kernels/internal/reference/integer_ops/conv.h b/tensorflow/lite/kernels/internal/reference/integer_ops/conv.h index 3e9cd0caa51..3a4164d3299 100644 --- a/tensorflow/lite/kernels/internal/reference/integer_ops/conv.h +++ b/tensorflow/lite/kernels/internal/reference/integer_ops/conv.h @@ -101,7 +101,7 @@ inline void ConvPerChannel( // long as the filter size (filter_y * filter_x * in_channel) // does not exceed 2^16, which is the case in all the models // we have seen so far. - // TODO(jianlijianli): Add a check to make sure the + // TODO(b/174275578): Add a check to make sure the // accumulator depth is smaller than 2^16. acc += filter_val * (input_val + input_offset); } diff --git a/tensorflow/lite/kernels/internal/reference/integer_ops/depthwise_conv.h b/tensorflow/lite/kernels/internal/reference/integer_ops/depthwise_conv.h index 6f54e47f344..f0ca09c74e1 100644 --- a/tensorflow/lite/kernels/internal/reference/integer_ops/depthwise_conv.h +++ b/tensorflow/lite/kernels/internal/reference/integer_ops/depthwise_conv.h @@ -95,7 +95,7 @@ inline void DepthwiseConvPerChannel( // long as the filter size (filter_y * filter_x * in_channel) // does not exceed 2^16, which is the case in all the models // we have seen so far. - // TODO(jianlijianli): Add a check to make sure the + // TODO(b/174275578): Add a check to make sure the // accumulator depth is smaller than 2^16. acc += filter_val * (input_val + input_offset); }