diff --git a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/chlo_ops.h b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/chlo_ops.h index 282b056d4cd..05b22770401 100644 --- a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/chlo_ops.h +++ b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/chlo_ops.h @@ -44,9 +44,15 @@ class HloClientDialect : public Dialect { static StringRef getDialectNamespace() { return "chlo"; } }; +} // namespace chlo +} // namespace mlir + #define GET_OP_CLASSES #include "mlir-hlo/Dialect/mhlo/IR/chlo_ops.h.inc" +namespace mlir { +namespace chlo { + template static Value getConstantLike(OpBuilder& b, Location loc, T constant, Value val) { diff --git a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/chlo_ops.td b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/chlo_ops.td index 5b6cf342538..04f984a5533 100644 --- a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/chlo_ops.td +++ b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/chlo_ops.td @@ -37,7 +37,7 @@ include "mlir-hlo/Dialect/mhlo/IR/infer_fusibility_op_interface.td" def HLOClient_Dialect : Dialect { let name = "chlo"; - let cppNamespace = "chlo"; + let cppNamespace = "::mlir::chlo"; let summary = [{ Client HLO Ops }]; diff --git a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/hlo_ops.h b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/hlo_ops.h index 4286c837a24..60ee4e613eb 100644 --- a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/hlo_ops.h +++ b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/hlo_ops.h @@ -19,7 +19,6 @@ limitations under the License. #define TENSORFLOW_COMPILER_MLIR_HLO_INCLUDE_MLIR_HLO_DIALECT_MHLO_IR_HLO_OPS_H_ #include "llvm/ADT/StringRef.h" -#include "mlir-hlo/Dialect/mhlo/IR/infer_fusibility_op_interface.h" #include "mlir/IR/Attributes.h" #include "mlir/IR/Dialect.h" #include "mlir/IR/DialectImplementation.h" @@ -32,11 +31,14 @@ limitations under the License. #include "mlir/Interfaces/InferTypeOpInterface.h" #include "mlir/Interfaces/SideEffectInterfaces.h" +// clang-format off +#include "mlir-hlo/Dialect/mhlo/IR/hlo_ops_structs.h.inc" +#include "mlir-hlo/Dialect/mhlo/IR/infer_fusibility_op_interface.h" +// clang-format on + namespace mlir { class OpBuilder; -#include "mlir-hlo/Dialect/mhlo/IR/hlo_ops_structs.h.inc" - namespace mhlo { class MhloDialect : public Dialect { @@ -77,10 +79,10 @@ LogicalResult deriveShapeFromFirstOperand( OpBuilder *builder, Operation *op, SmallVectorImpl *reifiedReturnShapes); -#define GET_OP_CLASSES -#include "mlir-hlo/Dialect/mhlo/IR/hlo_ops.h.inc" - } // end namespace mhlo } // end namespace mlir +#define GET_OP_CLASSES +#include "mlir-hlo/Dialect/mhlo/IR/hlo_ops.h.inc" + #endif // TENSORFLOW_COMPILER_MLIR_HLO_INCLUDE_MLIR_HLO_DIALECT_MHLO_IR_HLO_OPS_H_ diff --git a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/hlo_ops.td b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/hlo_ops.td index 037213645a1..22afeaa421e 100644 --- a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/hlo_ops.td +++ b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/hlo_ops.td @@ -27,7 +27,7 @@ include "mlir-hlo/Dialect/mhlo/IR/infer_fusibility_op_interface.td" def HLO_Dialect : Dialect { let name = "mhlo"; - let cppNamespace = "mhlo"; + let cppNamespace = "::mlir::mhlo"; } class HLO_Op traits> : diff --git a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/lhlo_ops.h b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/lhlo_ops.h index 6ad513d7b60..cc24e17c001 100644 --- a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/lhlo_ops.h +++ b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/lhlo_ops.h @@ -33,9 +33,11 @@ limitations under the License. namespace mlir { class OpBuilder; +} // namespace mlir #include "mlir-hlo/Dialect/mhlo/IR/lhlo_ops_structs.h.inc" +namespace mlir { namespace lmhlo { class LmhloDialect : public Dialect { @@ -44,10 +46,10 @@ class LmhloDialect : public Dialect { static StringRef getDialectNamespace() { return "lmhlo"; } }; -#define GET_OP_CLASSES -#include "mlir-hlo/Dialect/mhlo/IR/lhlo_ops.h.inc" - } // namespace lmhlo } // end namespace mlir +#define GET_OP_CLASSES +#include "mlir-hlo/Dialect/mhlo/IR/lhlo_ops.h.inc" + #endif // TENSORFLOW_COMPILER_MLIR_HLO_INCLUDE_MLIR_HLO_DIALECT_MHLO_IR_LHLO_OPS_H_ diff --git a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/lhlo_ops.td b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/lhlo_ops.td index 1c9820e2435..9225d0289dd 100644 --- a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/lhlo_ops.td +++ b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/lhlo_ops.td @@ -41,7 +41,7 @@ include "mlir-hlo/Dialect/mhlo/IR/hlo_ops_base.td" def LHLO_Dialect : Dialect { let name = "lmhlo"; - let cppNamespace = "lmhlo"; + let cppNamespace = "::mlir::lmhlo"; } //===----------------------------------------------------------------------===// diff --git a/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/chlo_ops.cc b/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/chlo_ops.cc index b5eacd686bd..99b22a75a14 100644 --- a/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/chlo_ops.cc +++ b/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/chlo_ops.cc @@ -303,9 +303,15 @@ void ConstantLikeOp::getCanonicalizationPatterns( results.insert(context); } +} // namespace chlo +} // namespace mlir + #define GET_OP_CLASSES #include "mlir-hlo/Dialect/mhlo/IR/chlo_ops.cc.inc" +namespace mlir { +namespace chlo { + //===----------------------------------------------------------------------===// // chlo Dialect Constructor //===----------------------------------------------------------------------===// diff --git a/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/hlo_ops.cc b/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/hlo_ops.cc index dc3dd21a4ab..fcd91f8f8ee 100644 --- a/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/hlo_ops.cc +++ b/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/hlo_ops.cc @@ -60,7 +60,11 @@ limitations under the License. namespace mlir { #include "hlo_patterns.cc.inc" +} // namespace mlir + #include "mlir-hlo/Dialect/mhlo/IR/hlo_ops_structs.cc.inc" + +namespace mlir { namespace mhlo { Operation* MhloDialect::materializeConstant(OpBuilder& builder, Attribute value, @@ -2469,9 +2473,15 @@ void CompareOp::build(OpBuilder& builder, OperationState& result, Value lhs, build(builder, result, new_type, lhs, rhs, comparison_direction); } +} // namespace mhlo +} // namespace mlir + #define GET_OP_CLASSES #include "mlir-hlo/Dialect/mhlo/IR/hlo_ops.cc.inc" +namespace mlir { +namespace mhlo { + //===----------------------------------------------------------------------===// // mhlo Dialect Interfaces //===----------------------------------------------------------------------===// diff --git a/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/lhlo_ops.cc b/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/lhlo_ops.cc index 81407c89204..cba0d3b4788 100644 --- a/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/lhlo_ops.cc +++ b/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/lhlo_ops.cc @@ -29,6 +29,7 @@ limitations under the License. #include "llvm/ADT/StringRef.h" #include "llvm/Support/FormatVariadic.h" #include "mlir-hlo/Dialect/mhlo/IR/lhlo_ops.h.inc" +#include "mlir-hlo/Dialect/mhlo/IR/lhlo_ops_structs.cc.inc" #include "mlir/Dialect/StandardOps/IR/Ops.h" #include "mlir/IR/Attributes.h" #include "mlir/IR/Builders.h" @@ -46,7 +47,6 @@ limitations under the License. #include "mlir/IR/Value.h" namespace mlir { -#include "mlir-hlo/Dialect/mhlo/IR/lhlo_ops_structs.cc.inc" namespace lmhlo { LmhloDialect::LmhloDialect(MLIRContext *context) @@ -159,9 +159,15 @@ static LogicalResult Verify(ReshapeMemRefCastOp op) { return success(); } +} // namespace lmhlo +} // namespace mlir + #define GET_OP_CLASSES #include "mlir-hlo/Dialect/mhlo/IR/lhlo_ops.cc.inc" +namespace mlir { +namespace lmhlo { + // TODO(cheshire): Support folding, reuse code from hlo_ops.cc. void FusionOp::build(OpBuilder &builder, OperationState &result, diff --git a/tensorflow/compiler/mlir/lite/converter_gen.cc b/tensorflow/compiler/mlir/lite/converter_gen.cc index edead2037a3..44eba0d5e6f 100644 --- a/tensorflow/compiler/mlir/lite/converter_gen.cc +++ b/tensorflow/compiler/mlir/lite/converter_gen.cc @@ -513,7 +513,7 @@ static bool RuntimeVerifierWriterMain(raw_ostream &os, RecordKeeper &records) { continue; } if (trait.getDef().getValueAsString("trait") != - "OpTrait::TFLRuntimeOpTrait") { + "::mlir::OpTrait::TFLRuntimeOpTrait") { continue; } diff --git a/tensorflow/compiler/mlir/lite/ir/tfl_ops.cc b/tensorflow/compiler/mlir/lite/ir/tfl_ops.cc index 104b84ceac0..2894af9b97e 100644 --- a/tensorflow/compiler/mlir/lite/ir/tfl_ops.cc +++ b/tensorflow/compiler/mlir/lite/ir/tfl_ops.cc @@ -41,10 +41,10 @@ limitations under the License. #include "mlir/Transforms/FoldUtils.h" // from @llvm-project #include "mlir/Transforms/InliningUtils.h" // from @llvm-project #include "mlir/Transforms/RegionUtils.h" // from @llvm-project +#include "tensorflow/compiler/mlir/lite/ir/tfl_structs.cc.inc" #include "tensorflow/compiler/mlir/tensorflow/ir/tf_types.h" namespace mlir { -#include "tensorflow/compiler/mlir/lite/ir/tfl_structs.cc.inc" namespace TFL { // Returns true when the given operand arguments have the same shape or @@ -2377,8 +2377,16 @@ LogicalResult WhileOp::moveOutOfLoop(llvm::ArrayRef ops) { //===----------------------------------------------------------------------===// #include "tensorflow/compiler/mlir/lite/ir/tfl_ops_interface.cc.inc" + +} // namespace TFL +} // namespace mlir + #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/lite/ir/tfl_ops.cc.inc" + +namespace mlir { +namespace TFL { + #include "tensorflow/compiler/mlir/lite/runtime_verifiers.inc" Operation *TensorFlowLiteDialect::materializeConstant(OpBuilder &builder, diff --git a/tensorflow/compiler/mlir/lite/ir/tfl_ops.h b/tensorflow/compiler/mlir/lite/ir/tfl_ops.h index d2d8442155b..589f18d789d 100644 --- a/tensorflow/compiler/mlir/lite/ir/tfl_ops.h +++ b/tensorflow/compiler/mlir/lite/ir/tfl_ops.h @@ -30,11 +30,11 @@ limitations under the License. #include "mlir/Interfaces/LoopLikeInterface.h" // from @llvm-project #include "mlir/Interfaces/SideEffectInterfaces.h" // from @llvm-project #include "mlir/Support/LLVM.h" // from @llvm-project +#include "tensorflow/compiler/mlir/lite/ir/tfl_structs.h.inc" #include "tensorflow/compiler/mlir/lite/quantization/quantization_utils.h" #include "tensorflow/lite/schema/schema_generated.h" namespace mlir { -#include "tensorflow/compiler/mlir/lite/ir/tfl_structs.h.inc" namespace TFL { class TensorFlowLiteDialect : public Dialect { @@ -50,10 +50,11 @@ class TensorFlowLiteDialect : public Dialect { }; #include "tensorflow/compiler/mlir/lite/ir/tfl_ops_interface.h.inc" -#define GET_OP_CLASSES -#include "tensorflow/compiler/mlir/lite/ir/tfl_ops.h.inc" } // end namespace TFL } // end namespace mlir +#define GET_OP_CLASSES +#include "tensorflow/compiler/mlir/lite/ir/tfl_ops.h.inc" + #endif // TENSORFLOW_COMPILER_MLIR_LITE_IR_TFL_OPS_H_ diff --git a/tensorflow/compiler/mlir/lite/ir/tfl_ops.td b/tensorflow/compiler/mlir/lite/ir/tfl_ops.td index 30690998b7b..1b91c0dbe61 100644 --- a/tensorflow/compiler/mlir/lite/ir/tfl_ops.td +++ b/tensorflow/compiler/mlir/lite/ir/tfl_ops.td @@ -39,7 +39,7 @@ def TFL_Dialect : Dialect { represented using zero-dimensional tensors); }]; - let cppNamespace = "TFL"; + let cppNamespace = "::mlir::TFL"; } //===----------------------------------------------------------------------===// diff --git a/tensorflow/compiler/mlir/lite/quantization/tools/op_quant_spec_getters_gen.cc b/tensorflow/compiler/mlir/lite/quantization/tools/op_quant_spec_getters_gen.cc index 208fb4c8a56..fc56ad05535 100644 --- a/tensorflow/compiler/mlir/lite/quantization/tools/op_quant_spec_getters_gen.cc +++ b/tensorflow/compiler/mlir/lite/quantization/tools/op_quant_spec_getters_gen.cc @@ -55,7 +55,7 @@ static bool OpQuantSpecWriter(raw_ostream &os, RecordKeeper &records) { for (const auto t : op.getTraits()) { if (auto opTrait = llvm::dyn_cast(&t)) { auto trait = opTrait->getTrait(); - if (!trait.consume_front("OpTrait::quant::")) continue; + if (!trait.consume_front("::mlir::OpTrait::quant::")) continue; OUT(2) << "if (auto tfl = llvm::dyn_cast<" << op.getQualCppClassName() << ">(op)) {\n"; @@ -65,7 +65,7 @@ static bool OpQuantSpecWriter(raw_ostream &os, RecordKeeper &records) { OUT(4) << "for (int i = 0, e = op->getNumResults(); i != e; ++i)\n"; OUT(6) << "spec->restricted_output_params[std::make_pair(" << matches[1] << ", " << matches[2] - << ")].push_back(tfl.OpTrait::quant::" << trait << "<" + << ")].push_back(tfl.::mlir::OpTrait::quant::" << trait << "<" << op.getQualCppClassName() << ">::GetResultQuantizedType(i));\n"; matches.clear(); diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_device.cc b/tensorflow/compiler/mlir/tensorflow/ir/tf_device.cc index 5f996b852ee..0e85582337d 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_device.cc +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_device.cc @@ -670,12 +670,12 @@ void LaunchOp::getCanonicalizationPatterns(OwningRewritePatternList& results, results.insert(context); } +} // namespace tf_device +} // namespace mlir + //===----------------------------------------------------------------------===// // TableGen'd op method definitions //===----------------------------------------------------------------------===// #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_device.cc.inc" - -} // namespace tf_device -} // namespace mlir diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_device.h b/tensorflow/compiler/mlir/tensorflow/ir/tf_device.h index 688c8ca5715..5b1d9711875 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_device.h +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_device.h @@ -41,11 +41,11 @@ class TensorFlowDeviceDialect : public Dialect { explicit TensorFlowDeviceDialect(MLIRContext* context); }; +} // namespace tf_device +} // namespace mlir + // Declares the operations for this dialect using the generated header. #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_device.h.inc" -} // namespace tf_device -} // namespace mlir - #endif // TENSORFLOW_COMPILER_MLIR_TENSORFLOW_IR_TF_DEVICE_H_ diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_device_ops.td b/tensorflow/compiler/mlir/tensorflow/ir/tf_device_ops.td index d94a37d9b02..8f1cd6877e4 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_device_ops.td +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_device_ops.td @@ -36,7 +36,7 @@ def TfDevice_Dialect : Dialect { XlaRun. }]; - let cppNamespace = "tf_device"; + let cppNamespace = "::mlir::tf_device"; } //===----------------------------------------------------------------------===// diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_executor.cc b/tensorflow/compiler/mlir/tensorflow/ir/tf_executor.cc index eced738b0a5..f2d0a548420 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_executor.cc +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_executor.cc @@ -1121,12 +1121,12 @@ LogicalResult IslandOp::fold(llvm::ArrayRef operands, return success(); } +} // namespace tf_executor +} // namespace mlir + //===----------------------------------------------------------------------===// // TableGen'd op method definitions //===----------------------------------------------------------------------===// #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_executor.cc.inc" - -} // namespace tf_executor -} // namespace mlir diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_executor.h b/tensorflow/compiler/mlir/tensorflow/ir/tf_executor.h index 60036ddc9f8..2bc13556b4b 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_executor.h +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_executor.h @@ -57,11 +57,11 @@ class TokenType : public Type::TypeBase { using Base::Base; }; +} // namespace tf_executor +} // namespace mlir + // Declares the operations for this dialect using the generated header. #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_executor.h.inc" -} // namespace tf_executor -} // namespace mlir - #endif // TENSORFLOW_COMPILER_MLIR_TENSORFLOW_IR_TF_EXECUTOR_H_ diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_executor_ops.td b/tensorflow/compiler/mlir/tensorflow/ir/tf_executor_ops.td index de2d2485628..713ddc44cba 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_executor_ops.td +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_executor_ops.td @@ -43,7 +43,7 @@ def TfExecutor_Dialect : Dialect { value). }]; - let cppNamespace = "tf_executor"; + let cppNamespace = "::mlir::tf_executor"; } // Control type. diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_op_base.td b/tensorflow/compiler/mlir/tensorflow/ir/tf_op_base.td index 396f00ee3c3..325a196330b 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_op_base.td +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_op_base.td @@ -46,7 +46,7 @@ Invariants: TODO: Make invariants more structured so that we can reference them in ops. }]; - let cppNamespace = "TF"; + let cppNamespace = "::mlir::TF"; } //===----------------------------------------------------------------------===// diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.cc b/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.cc index 5bf4f829712..953236602f9 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.cc +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.cc @@ -2294,12 +2294,12 @@ OpFoldResult MulOp::fold(ArrayRef operands) { return IdentityArithmeticOpFolder(*this, operands); } +} // namespace TF +} // namespace mlir + //===----------------------------------------------------------------------===// // TableGen'd op method definitions //===----------------------------------------------------------------------===// #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.cc.inc" - -} // namespace TF -} // namespace mlir diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.h b/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.h index 19a927a23d7..8d98632b198 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.h +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.h @@ -43,6 +43,9 @@ namespace TF { class YieldOp; +} // namespace TF +} // namespace mlir + // TODO(b/131258166): TensorFlow's mutex.h defines a `mutex_lock` macro, whose // purpose is to catch bug on `tensorflow::mutex_lock`. We don't use // `tensorflow::mutex_lock` here but we have ops (`tf.MutexLock` and @@ -56,7 +59,4 @@ class YieldOp; #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.h.inc" -} // namespace TF -} // namespace mlir - #endif // TENSORFLOW_COMPILER_MLIR_TENSORFLOW_IR_TF_OPS_A_M_H_ diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.cc b/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.cc index c88d10efbad..89e139edd6d 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.cc +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.cc @@ -2490,12 +2490,12 @@ void XdivyOp::getCanonicalizationPatterns(OwningRewritePatternList &results, results.insert(context); } +} // namespace TF +} // namespace mlir + //===----------------------------------------------------------------------===// // TableGen'd op method definitions //===----------------------------------------------------------------------===// #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.cc.inc" - -} // namespace TF -} // namespace mlir diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.h b/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.h index 761c06a475c..9b06d855b01 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.h +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.h @@ -38,15 +38,9 @@ limitations under the License. #include "tensorflow/compiler/mlir/tensorflow/ir/tf_types.h" #include "tensorflow/compiler/mlir/tensorflow/ir/tf_verifiers.h" -namespace mlir { -namespace TF { - #define GET_OP_FWD_DEFINES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_all_ops.h.inc" #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.h.inc" -} // namespace TF -} // namespace mlir - #endif // TENSORFLOW_COMPILER_MLIR_TENSORFLOW_IR_TF_OPS_N_Z_H_ diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_remaining_ops.cc b/tensorflow/compiler/mlir/tensorflow/ir/tf_remaining_ops.cc index e87cc494a4a..38f9175a500 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_remaining_ops.cc +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_remaining_ops.cc @@ -70,11 +70,12 @@ limitations under the License. namespace mlir { namespace TF { - namespace { #include "tensorflow/compiler/mlir/tensorflow/ir/tf_ops_helpers.inc" #include "tensorflow/compiler/mlir/tensorflow/transforms/generated_canonicalize.inc" } // namespace +} // namespace TF +} // namespace mlir //===----------------------------------------------------------------------===// // TableGen'd op method definitions @@ -82,6 +83,3 @@ namespace { #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_remaining_ops.cc.inc" - -} // namespace TF -} // namespace mlir diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_remaining_ops.h b/tensorflow/compiler/mlir/tensorflow/ir/tf_remaining_ops.h index 8586515edee..589e0e91615 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_remaining_ops.h +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_remaining_ops.h @@ -36,15 +36,9 @@ limitations under the License. #include "tensorflow/compiler/mlir/tensorflow/ir/tf_types.h" #include "tensorflow/compiler/mlir/tensorflow/ir/tf_verifiers.h" -namespace mlir { -namespace TF { - #define GET_OP_FWD_DEFINES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_all_ops.h.inc" #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_remaining_ops.h.inc" -} // namespace TF -} // namespace mlir - #endif // TENSORFLOW_COMPILER_MLIR_TENSORFLOW_IR_TF_REMAINING_OPS_H_ diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model.cc b/tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model.cc index 2eaa511dbfe..1eaf997ab69 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model.cc +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model.cc @@ -105,9 +105,15 @@ static LogicalResult Verify(SessionInitializerOp session_initializer) { return success(); } +} // namespace tf_saved_model +} // namespace mlir + #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model.cc.inc" +namespace mlir { +namespace tf_saved_model { + //===----------------------------------------------------------------------===// // TensorFlowSavedModelDialect Dialect //===----------------------------------------------------------------------===// diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model.h b/tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model.h index 02b7f0b75f4..c8518a9ca02 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model.h +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model.h @@ -40,10 +40,16 @@ class TensorFlowSavedModelDialect : public Dialect { static StringRef getDialectNamespace() { return "tf_saved_model"; } }; +} // namespace tf_saved_model +} // namespace mlir + // Declares the operations for this dialect using the generated header. #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model.h.inc" +namespace mlir { +namespace tf_saved_model { + // Returns the list of exported names for `op`. // An empty list means `op` is not exported. SmallVector GetExportedNames(Operation *op); diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model_ops.td b/tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model_ops.td index a22a684953b..753e2368d6e 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model_ops.td +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model_ops.td @@ -82,7 +82,7 @@ def TfSavedModel_Dialect : Dialect { with "get_global @some_global_tensor" in the function body. }]; - let cppNamespace = "tf_saved_model"; + let cppNamespace = "::mlir::tf_saved_model"; } diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_structs.cc b/tensorflow/compiler/mlir/tensorflow/ir/tf_structs.cc index 6c5485c16dd..9d8f25c6633 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_structs.cc +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_structs.cc @@ -15,11 +15,9 @@ limitations under the License. #include "tensorflow/compiler/mlir/tensorflow/ir/tf_structs.h" -namespace mlir { - -// NOLINTNEXTLINE #include "tensorflow/compiler/mlir/tensorflow/ir/tf_structs.cc.inc" +namespace mlir { namespace TF { void RuntimeDevices::AddDevice(const ParsedName& device) { diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_structs.h b/tensorflow/compiler/mlir/tensorflow/ir/tf_structs.h index b1f39ad1d28..b90bf2d47a8 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tf_structs.h +++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_structs.h @@ -26,10 +26,9 @@ limitations under the License. #include "mlir/IR/Types.h" // from @llvm-project #include "tensorflow/core/util/device_name_utils.h" -namespace mlir { - #include "tensorflow/compiler/mlir/tensorflow/ir/tf_structs.h.inc" +namespace mlir { namespace TF { // Tensorflow devices available at runtime with corresponding metadata if it is diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tfrt_ops.cc b/tensorflow/compiler/mlir/tensorflow/ir/tfrt_ops.cc index 566ea8821bf..6a6a7574f29 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tfrt_ops.cc +++ b/tensorflow/compiler/mlir/tensorflow/ir/tfrt_ops.cc @@ -19,15 +19,9 @@ limitations under the License. #include "mlir/IR/TypeUtilities.h" // from @llvm-project #include "mlir/IR/Types.h" // from @llvm-project -namespace mlir { -namespace TF { - //===----------------------------------------------------------------------===// // TableGen'd op method definitions //===----------------------------------------------------------------------===// #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tfrt_ops.cc.inc" - -} // namespace TF -} // namespace mlir diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tfrt_ops.h b/tensorflow/compiler/mlir/tensorflow/ir/tfrt_ops.h index 0b2188aea93..039f211533c 100644 --- a/tensorflow/compiler/mlir/tensorflow/ir/tfrt_ops.h +++ b/tensorflow/compiler/mlir/tensorflow/ir/tfrt_ops.h @@ -20,13 +20,7 @@ limitations under the License. #include "mlir/Interfaces/InferTypeOpInterface.h" // from @llvm-project #include "mlir/Interfaces/SideEffectInterfaces.h" // from @llvm-project -namespace mlir { -namespace TF { - #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tensorflow/ir/tfrt_ops.h.inc" -} // namespace TF -} // namespace mlir - #endif // TENSORFLOW_COMPILER_MLIR_TENSORFLOW_IR_TFRT_OPS_H_ diff --git a/tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.cc b/tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.cc index 331bed09dce..5ea3f51b475 100644 --- a/tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.cc +++ b/tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.cc @@ -15,12 +15,12 @@ limitations under the License. #include "tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.h" -namespace mlir { -namespace tfjs { - #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.cc.inc" +namespace mlir { +namespace tfjs { + //===----------------------------------------------------------------------===// // TFJSDialect //===----------------------------------------------------------------------===// diff --git a/tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.h b/tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.h index 9c98c9b0e19..bc52e3a0c7a 100644 --- a/tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.h +++ b/tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.h @@ -29,15 +29,9 @@ limitations under the License. #include "mlir/Interfaces/SideEffectInterfaces.h" // from @llvm-project #include "mlir/Support/LLVM.h" // from @llvm-project -namespace mlir { -namespace tfjs { - #include "tensorflow/compiler/mlir/tfjs/ir/tfjs_dialect.h.inc" #define GET_OP_CLASSES #include "tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.h.inc" -} // namespace tfjs -} // namespace mlir - #endif // TENSORFLOW_COMPILER_MLIR_TFJS_IR_TFJS_OPS_H_ diff --git a/tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.td b/tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.td index 134aa010d8c..e2539c2f6d8 100644 --- a/tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.td +++ b/tensorflow/compiler/mlir/tfjs/ir/tfjs_ops.td @@ -39,7 +39,7 @@ def TFJSDialect : Dialect { TF graphs to be deployed on TFJS. }]; - let cppNamespace = "tfjs"; + let cppNamespace = "::mlir::tfjs"; } //===----------------------------------------------------------------------===// diff --git a/tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.cc b/tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.cc index 8c02a734f1d..b3d92773be4 100644 --- a/tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.cc +++ b/tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.cc @@ -77,9 +77,9 @@ LogicalResult Verify(AllocRawOp op) { return success(); } -#define GET_OP_CLASSES -#include "tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.cc.inc" - } // namespace tf_framework } // namespace kernel_gen } // namespace mlir + +#define GET_OP_CLASSES +#include "tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.cc.inc" diff --git a/tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.h b/tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.h index d2612a38799..aab090cc5e0 100644 --- a/tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.h +++ b/tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.h @@ -38,12 +38,12 @@ class OpKernelContextType using Base::Base; }; -#define GET_OP_CLASSES -#include "tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_dialect.h.inc" -#include "tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.h.inc" - } // namespace tf_framework } // namespace kernel_gen } // namespace mlir +#define GET_OP_CLASSES +#include "tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_dialect.h.inc" +#include "tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.h.inc" + #endif // TENSORFLOW_COMPILER_MLIR_TOOLS_KERNEL_GEN_IR_TF_FRAMEWORK_OPS_H_ diff --git a/tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.td b/tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.td index bc390a5aaa5..e6e29bcbdc2 100644 --- a/tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.td +++ b/tensorflow/compiler/mlir/tools/kernel_gen/ir/tf_framework_ops.td @@ -29,7 +29,7 @@ def TFFramework_Dialect : Dialect { This dialect contains operations and types for that correspond to TensorFlow C++ Framework. }]; - let cppNamespace = "kernel_gen::tf_framework"; + let cppNamespace = "::mlir::kernel_gen::tf_framework"; } def TFFramework_OpKernelContextType : DialectType