experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Re-enabling the XLA convolution_test on the ROCm platform, after disabling a couple of failing subtests. Those failing subtests will be fixed soon

Browse Source
This commit is contained in:
Deven Desai 2021-01-07 16:00:14 +00:00
parent 98aecfccda
commit 55ed8659f4
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tensorflow/compiler/xla/tests/BUILD
View File

@ -1116,7 +1116,6 @@ xla_test(
srcs = ["convolution_test.cc"], srcs = ["convolution_test.cc"],
shard_count = 50, shard_count = 50,
tags = [ tags = [
"no_rocm",
"optonly", "optonly",
# Timed out on 2020-07-18 # Timed out on 2020-07-18
"nozapfhahn", "nozapfhahn",

4
tensorflow/compiler/xla/tests/convolution_test.cc
View File

@ -1573,7 +1573,7 @@ XLA_TEST_F(ConvolutionTest, Convolve_bf16_1x1x1x2_1x1x1x2_Valid) {
// Check that GPU convs still work if the CudnnAlgorithmPicker pass is disabled. // Check that GPU convs still work if the CudnnAlgorithmPicker pass is disabled.
// (We run this test on all platforms, because, what the heck.) // (We run this test on all platforms, because, what the heck.)
XLA_TEST_F(ConvolutionTest, NoCudnnAlgorithmPicker) { XLA_TEST_F(ConvolutionTest, DISABLED_ON_GPU_ROCM(NoCudnnAlgorithmPicker)) {
execution_options_.mutable_debug_options()->add_xla_disable_hlo_passes( execution_options_.mutable_debug_options()->add_xla_disable_hlo_passes(
"gpu-conv-algorithm-picker"); "gpu-conv-algorithm-picker");
@ -1644,7 +1644,7 @@ ENTRY Test {
EXPECT_TRUE(RunAndCompare(kHlo, ErrorSpec{0.001})); EXPECT_TRUE(RunAndCompare(kHlo, ErrorSpec{0.001}));
} }
XLA_TEST_F(ConvolutionHloTest, ConvolveF32ForwardReversed) { XLA_TEST_F(ConvolutionHloTest, DISABLED_ON_GPU_ROCM(ConvolveF32ForwardReversed)) {
constexpr char kHlo[] = R"( constexpr char kHlo[] = R"(
HloModule TestModule HloModule TestModule