diff --git a/tensorflow/compiler/xla/service/mlir_gpu/kernel_lowering.cc b/tensorflow/compiler/xla/service/mlir_gpu/kernel_lowering.cc index c698ec72bae..b738c40c374 100644 --- a/tensorflow/compiler/xla/service/mlir_gpu/kernel_lowering.cc +++ b/tensorflow/compiler/xla/service/mlir_gpu/kernel_lowering.cc @@ -236,10 +236,10 @@ class LowerToROCDLPass ::mlir::ConversionTarget target(getContext()); target.addIllegalDialect<::mlir::gpu::GPUDialect>(); - target - .addIllegalOp(); + target.addIllegalOp(); target.addIllegalOp(); target.addLegalDialect<::mlir::LLVM::LLVMDialect>(); target.addLegalDialect<::mlir::ROCDL::ROCDLDialect>(); diff --git a/tensorflow/core/kernels/mlir_generated/BUILD b/tensorflow/core/kernels/mlir_generated/BUILD index 38cfc5db641..b47fdbee1df 100644 --- a/tensorflow/core/kernels/mlir_generated/BUILD +++ b/tensorflow/core/kernels/mlir_generated/BUILD @@ -302,21 +302,6 @@ gen_kernel_library( unroll_factors = "4", ) -# Temporarily disabled due to failure on ROCM, fix will come soon. -# gen_kernel_library( -# name = "sin", -# generate_ranked = False, -# generate_unranked = True, -# tags = ["no_rocm"], -# tile_size = "256", -# types = [ -# "f16", -# "f32", -# "f64", -# ], -# unroll_factors = "4", -# ) - gen_kernel_library( name = "addv2", generate_ranked = False, @@ -352,6 +337,7 @@ gen_kernel_library( "log", "neg", "rsqrt", + "sin", "sqrt", "tanh", ]