experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Issue a warning if there are no quantization parameters on the output of concat

Browse Source 
PiperOrigin-RevId: 296500231
Change-Id: I76423aceeef11ebff01c6267f8560598a4a00817
This commit is contained in:
Feng Liu 2020-02-21 13:31:39 -08:00 committed by TensorFlower Gardener
parent 0b312cbc55
commit 44627ed200
1 changed files with 24 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
tensorflow/compiler/mlir/lite/transforms/prepare_quantize.cc
View File

@ -189,6 +189,16 @@ bool PrepareQuantizePass::RemoveRedundantStats(FuncOp func) {
return RemoveRedundantStatsOps(func, GetOpQuantSpec); return RemoveRedundantStatsOps(func, GetOpQuantSpec);
} }
static Value Quantized(Operation* user) {
if (auto q = llvm::dyn_cast_or_null<quant::QuantizeCastOp>(user)) {
if (auto dq = llvm::dyn_cast_or_null<quant::DequantizeCastOp>(
*q.getResult().user_begin())) {
return dq.getResult();
}
}
return {};
}
void PrepareQuantizePass::SanityCheckAndAdjustment(FuncOp func) { void PrepareQuantizePass::SanityCheckAndAdjustment(FuncOp func) {
// If an op output has two users: one of them is a quantize op and another // If an op output has two users: one of them is a quantize op and another
// one is returned directly, we decide to return the quantized result instead, // one is returned directly, we decide to return the quantized result instead,
@ -199,11 +209,8 @@ void PrepareQuantizePass::SanityCheckAndAdjustment(FuncOp func) {
for (Value returned : ret.operands()) { for (Value returned : ret.operands()) {
llvm::SmallVector<Value, 4> quantized; llvm::SmallVector<Value, 4> quantized;
for (auto user : returned.getUsers()) { for (auto user : returned.getUsers()) {
if (auto q = llvm::dyn_cast_or_null<quant::QuantizeCastOp>(user)) { if (auto q = Quantized(user)) {
if (auto dq = llvm::dyn_cast_or_null<quant::DequantizeCastOp>( quantized.push_back(q);
*q.getResult().user_begin())) {
quantized.push_back(dq.getResult());
}
} }
} }
if (quantized.size() == 1) { if (quantized.size() == 1) {
@ -212,6 +219,18 @@ void PrepareQuantizePass::SanityCheckAndAdjustment(FuncOp func) {
i++; i++;
} }
}); });
// We prefer to placing quantization emulation ops on the results of the
// concat ops.
func.walk([&](ConcatenationOp concat) {
if (concat.output().hasOneUse() &&
Quantized(*concat.output().user_begin())) {
return;
}
concat.emitWarning(
"Missing quantization parameter on the output might introduce "
"quantization error!");
});
} }
using PrepareQuantStats = using PrepareQuantStats =