experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make explicit promotion in signed/unsigned comparison.

Browse Source 
As signed index is verified to be >= 0 at the point of compare with the unsigned size, we can make the compare explicitly an unsigned compare by casting index. Also avoids -Wsign-compare warning where enabled.

PiperOrigin-RevId: 261321178
This commit is contained in:
Jacques Pienaar 2019-08-02 07:56:59 -07:00 committed by TensorFlower Gardener
parent 263c00065d
commit 4181b8b6fe
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tensorflow/core/util/tensor_format.h
View File

@ -20,6 +20,7 @@ limitations under the License.
#include <vector>
#include "tensorflow/core/framework/tensor.h"
#include "tensorflow/core/lib/gtl/array_slice.h"
#include "tensorflow/core/lib/gtl/inlined_vector.h"
#include "tensorflow/core/platform/types.h"
@ -441,7 +442,9 @@ T GetFilterDim(gtl::ArraySlice<T> dimension_attribute,
filter_tensor_format) == 3)
? GetFilterDimIndex<3>(filter_tensor_format, dimension)
: GetFilterDimIndex<2>(filter_tensor_format, dimension);
CHECK(index >= 0 && index < dimension_attribute.size())
using size_type = typename gtl::ArraySlice<T>::size_type;
CHECK(index >= 0 &&
static_cast<size_type>(index) < dimension_attribute.size())
<< "Invalid index from the dimension: " << index << ", "
<< filter_tensor_format << ", " << dimension;
return dimension_attribute[index];