From 83bc3e976ea9fb118959ffd8d267b35a7edf25fe Mon Sep 17 00:00:00 2001 From: Jeffrey Poznanovic Date: Tue, 12 Feb 2019 07:24:55 -0800 Subject: [PATCH 1/3] Adding no_rocm tags to failing unit tests that were previously excluded via run_py3_core.sh --- tensorflow/python/BUILD | 1 + tensorflow/python/eager/BUILD | 2 ++ tensorflow/python/keras/BUILD | 8 +++++++- tensorflow/python/kernel_tests/BUILD | 8 ++++++++ tensorflow/python/kernel_tests/signal/BUILD | 11 +++++++++-- tensorflow/python/ops/parallel_for/BUILD | 1 + tensorflow/python/training/checkpointable/BUILD | 1 + tensorflow/tools/api/tests/BUILD | 1 + 8 files changed, 30 insertions(+), 3 deletions(-) diff --git a/tensorflow/python/BUILD b/tensorflow/python/BUILD index a6d68684989..710841c675f 100644 --- a/tensorflow/python/BUILD +++ b/tensorflow/python/BUILD @@ -3644,6 +3644,7 @@ cuda_py_test( "//third_party/py/numpy", ], shard_count = 16, + tags = ["no_rocm"], ) cuda_py_test( diff --git a/tensorflow/python/eager/BUILD b/tensorflow/python/eager/BUILD index 47a7e9ae2f5..a6a367e2685 100644 --- a/tensorflow/python/eager/BUILD +++ b/tensorflow/python/eager/BUILD @@ -151,6 +151,7 @@ cuda_py_test( "//tensorflow/python:nn_grad", "//tensorflow/python:training", ], + tags = ["no_rocm"], ) cuda_py_test( @@ -530,6 +531,7 @@ tf_xla_py_test( srcs = ["def_function_xla_test.py"], tags = [ "no_pip", + "no_rocm", "nomac", ], deps = [ diff --git a/tensorflow/python/keras/BUILD b/tensorflow/python/keras/BUILD index 4f710ff658e..fcd01bba120 100755 --- a/tensorflow/python/keras/BUILD +++ b/tensorflow/python/keras/BUILD @@ -607,7 +607,10 @@ cuda_py_test( "//tensorflow/python:client_testlib", ], shard_count = 4, - tags = ["no_windows_gpu"], + tags = [ + "no_rocm", + "no_windows_gpu", + ], ) tf_py_test( @@ -778,6 +781,7 @@ cuda_py_test( "//tensorflow/python:client_testlib", ], shard_count = 8, + tags = ["no_rocm"], ) cuda_py_test( @@ -791,6 +795,7 @@ cuda_py_test( "//tensorflow/python:client_testlib", ], shard_count = 8, + tags = ["no_rocm"], ) tf_py_test( @@ -1181,6 +1186,7 @@ tf_py_test( "//third_party/py/numpy", "//tensorflow/python:client_testlib", ], + tags = ["no_rocm"], ) tf_py_test( diff --git a/tensorflow/python/kernel_tests/BUILD b/tensorflow/python/kernel_tests/BUILD index 75a8fa2a682..5fb7357e100 100644 --- a/tensorflow/python/kernel_tests/BUILD +++ b/tensorflow/python/kernel_tests/BUILD @@ -131,6 +131,7 @@ cuda_py_test( "//tensorflow/python:client_testlib", ], grpc_enabled = True, + tags = ["no_rocm"], xla_enable_strict_auto_jit = True, ) @@ -1688,6 +1689,7 @@ cuda_py_test( "//tensorflow/python:framework_for_generated_wrappers", "//tensorflow/python:nn_ops", ], + tags = ["no_rocm"], xla_enable_strict_auto_jit = True, ) @@ -2605,6 +2607,7 @@ cuda_py_test( "//tensorflow/python/eager:context", ], flaky = 1, # create_local_cluster sometimes times out. + tags = ["no_rocm"], xla_enable_strict_auto_jit = True, ) @@ -2764,6 +2767,7 @@ cuda_py_test( ], shard_count = 2, tags = [ + "no_rocm", "optonly", # flaky timeouts unless optimized ], xla_enable_strict_auto_jit = True, @@ -2805,6 +2809,7 @@ cuda_py_test( ], shard_count = 4, tags = [ + "no_rocm", "optonly", # times out ], xla_enable_strict_auto_jit = True, @@ -2868,6 +2873,7 @@ cuda_py_test( "//tensorflow/python:nn_grad", "//tensorflow/python:nn_ops", ], + tags = ["no_rocm"], xla_enable_strict_auto_jit = True, ) @@ -2887,6 +2893,7 @@ cuda_py_test( "//tensorflow/python:nn_ops_gen", ], shard_count = 4, + tags = ["no_rocm"], xla_enable_strict_auto_jit = True, ) @@ -3145,6 +3152,7 @@ cuda_py_test( "//tensorflow/python:nn_ops", ], shard_count = 30, + tags = ["no_rocm"], xla_enable_strict_auto_jit = True, ) diff --git a/tensorflow/python/kernel_tests/signal/BUILD b/tensorflow/python/kernel_tests/signal/BUILD index 554bf380294..29eb6ab6747 100644 --- a/tensorflow/python/kernel_tests/signal/BUILD +++ b/tensorflow/python/kernel_tests/signal/BUILD @@ -29,6 +29,7 @@ cuda_py_tests( "//tensorflow/python:spectral_ops_test_util", "//tensorflow/python/ops/signal", ], + tags = ["no_rocm"], xla_enable_strict_auto_jit = True, ) @@ -45,7 +46,10 @@ cuda_py_tests( "//tensorflow/python/ops/signal", ], shard_count = 4, - tags = ["optonly"], + tags = [ + "no_rocm", + "optonly", + ], xla_enable_strict_auto_jit = True, ) @@ -130,7 +134,10 @@ cuda_py_tests( "//tensorflow/python:spectral_ops_test_util", "//tensorflow/python/ops/signal", ], - tags = ["nomac"], + tags = [ + "no_rocm", + "nomac", + ], xla_enable_strict_auto_jit = True, ) diff --git a/tensorflow/python/ops/parallel_for/BUILD b/tensorflow/python/ops/parallel_for/BUILD index 05d2e4c7fcd..3c694c76401 100644 --- a/tensorflow/python/ops/parallel_for/BUILD +++ b/tensorflow/python/ops/parallel_for/BUILD @@ -115,6 +115,7 @@ cuda_py_test( "//tensorflow/python:random_ops", "//tensorflow/python:util", ], + tags = ["no_rocm"], ) cuda_py_test( diff --git a/tensorflow/python/training/checkpointable/BUILD b/tensorflow/python/training/checkpointable/BUILD index e1f58a9e4be..b7d28fee530 100644 --- a/tensorflow/python/training/checkpointable/BUILD +++ b/tensorflow/python/training/checkpointable/BUILD @@ -195,6 +195,7 @@ tf_xla_py_test( srcs = ["util_xla_test.py"], tags = [ "no_pip", + "no_rocm", "nomac", "notsan", # b/74395663 ], diff --git a/tensorflow/tools/api/tests/BUILD b/tensorflow/tools/api/tests/BUILD index 4efa4a9651f..ba178af0f61 100644 --- a/tensorflow/tools/api/tests/BUILD +++ b/tensorflow/tools/api/tests/BUILD @@ -35,6 +35,7 @@ py_test( "//tensorflow/tools/common:public_api", "//tensorflow/tools/common:traverse", ], + tags = ["no_rocm"], ) tf_cc_binary( From 54d344e6e58dfea50c1737316f1135fe0551720e Mon Sep 17 00:00:00 2001 From: Jeff Poznanovic Date: Wed, 13 Feb 2019 00:25:04 -0700 Subject: [PATCH 2/3] Add additional no_rocm tag for mfcc_ops_test --- tensorflow/python/kernel_tests/signal/BUILD | 1 + 1 file changed, 1 insertion(+) diff --git a/tensorflow/python/kernel_tests/signal/BUILD b/tensorflow/python/kernel_tests/signal/BUILD index 29eb6ab6747..4caecc85ca5 100644 --- a/tensorflow/python/kernel_tests/signal/BUILD +++ b/tensorflow/python/kernel_tests/signal/BUILD @@ -77,6 +77,7 @@ cuda_py_tests( "//tensorflow/python/ops/signal", "//tensorflow/python:spectral_ops_test_util", ], + tags = ["no_rocm"], xla_enable_strict_auto_jit = True, ) From 21a83324df6f33ccb9c276d4a28f83902d990899 Mon Sep 17 00:00:00 2001 From: Jeff Poznanovic Date: Wed, 13 Feb 2019 18:04:49 -0700 Subject: [PATCH 3/3] Add no_rocm tag to self_adjoint_eig_op_test_gpu The kernel_tests:self_adjoint_eig_op_test_gpu unit test fails occasionally on ROCm. Disabling / tagging as "no_rocm" (and flaky). --- tensorflow/python/kernel_tests/BUILD | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tensorflow/python/kernel_tests/BUILD b/tensorflow/python/kernel_tests/BUILD index 5fb7357e100..308b4585c07 100644 --- a/tensorflow/python/kernel_tests/BUILD +++ b/tensorflow/python/kernel_tests/BUILD @@ -3291,7 +3291,10 @@ cuda_py_test( ], data = ["//tensorflow/python/kernel_tests/testdata:self_adjoint_eig_op_test_files"], shard_count = 20, - tags = ["no_windows"], + tags = [ + "no_rocm", # flaky test + "no_windows", + ], xla_enable_strict_auto_jit = True, )