From 61133370602a5fc7b3313ea7f8f745dae66b3c38 Mon Sep 17 00:00:00 2001 From: "G. Hussain Chinoy" Date: Thu, 6 Jun 2019 21:13:16 -0600 Subject: [PATCH 1/2] Update ag_logging.py with clarity and reference * fixes typo * adds clarity to text * adds reference to absl's logging doc page ref #29250 --- tensorflow/python/autograph/utils/ag_logging.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tensorflow/python/autograph/utils/ag_logging.py b/tensorflow/python/autograph/utils/ag_logging.py index e8e8de5c593..06bb98348c7 100644 --- a/tensorflow/python/autograph/utils/ag_logging.py +++ b/tensorflow/python/autograph/utils/ag_logging.py @@ -46,7 +46,7 @@ def set_verbosity(level, alsologtostdout=False): More verbose logging is useful to enable when filing bug reports or doing more in-depth debugging. - There are two controls that control the logging verbosity: + There are two parameters that control the logging verbosity: * The `set_verbosity` function @@ -70,7 +70,8 @@ def set_verbosity(level, alsologtostdout=False): # No effect, because set_verbosity was already called. ``` - Logs entries are output to [absl](https://abseil.io)'s default output, + Logs entries are output to [absl](https://abseil.io)'s + [default output](https://abseil.io/docs/python/guides/logging), with `INFO` level. Logs can be mirrored to stdout by using the `alsologtostdout` argument. Mirroring is enabled by default when Python runs in interactive mode. @@ -78,7 +79,7 @@ def set_verbosity(level, alsologtostdout=False): Args: level: int, the verbosity level; larger values specify increased verbosity; 0 means no logging. When reporting bugs, it is recommended to set this - value to a larges number, like 10. + value to a larger number, like 10. alsologtostdout: bool, whether to also output log messages to `sys.stdout`. """ global verbosity_level From f24abcb2519e6d92e6954b501d5e09e24ec0f093 Mon Sep 17 00:00:00 2001 From: "G. Hussain Chinoy" Date: Sun, 16 Jun 2019 12:03:06 -0600 Subject: [PATCH 2/2] modified wording for 'control' --- tensorflow/python/autograph/utils/ag_logging.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tensorflow/python/autograph/utils/ag_logging.py b/tensorflow/python/autograph/utils/ag_logging.py index 06bb98348c7..fa67d1eeda1 100644 --- a/tensorflow/python/autograph/utils/ag_logging.py +++ b/tensorflow/python/autograph/utils/ag_logging.py @@ -46,7 +46,7 @@ def set_verbosity(level, alsologtostdout=False): More verbose logging is useful to enable when filing bug reports or doing more in-depth debugging. - There are two parameters that control the logging verbosity: + There are two means to control the logging verbosity: * The `set_verbosity` function