experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

When a new dataset is loaded, the 3D label visualizer now forgets its label

Browse Source 
accessor. The projector data panel updates the dataset before messing with its
own UI, which can lead to Polymer property events. The data set needs to be
updated throughout the app before events can meaningfully fire.
Change: 136073118
This commit is contained in:
Charles Nicholson 2016-10-13 11:39:33 -08:00 committed by TensorFlower Gardener
parent 3d84306711
commit 2c34669f89
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tensorflow/tensorboard/components/vz-projector/scatterPlotVisualizer3DLabels.ts
View File

@ -295,11 +295,8 @@ export class ScatterPlotVisualizer3DLabels implements ScatterPlotVisualizer {
}
private colorSprites(pointColors?: Float32Array) {
if (this.geometry == null || this.dataSet == null) {
return;
}
if (pointColors == null) {
if (this.labelAccessor == null || this.geometry == null ||
this.dataSet == null || pointColors == null) {
return;
}
@ -341,6 +338,7 @@ export class ScatterPlotVisualizer3DLabels implements ScatterPlotVisualizer {
onDataSet(dataSet: DataSet, spriteImage: HTMLImageElement) {
this.dataSet = dataSet;
this.labelAccessor = null;
}
onPickingRender(rc: RenderContext) {

2
tensorflow/tensorboard/components/vz-projector/vz-projector-data-panel.ts
View File

@ -170,8 +170,8 @@ export class DataPanel extends DataPanelPolymer {
if (metadataFile) {
this.dataProvider.retrieveMetadata(
this.selectedRun, this.selectedTensor, metadata => {
this.updateMetadataUI(metadata.stats, metadataFile);
this.projector.updateDataSet(ds, metadata);
this.updateMetadataUI(metadata.stats, metadataFile);
});
} else {
this.projector.updateDataSet(ds, null);