[XLA/GPU] Fix compilation warnings.

This commit is contained in:
Trent Lo 2020-08-31 18:39:46 -07:00
parent 8c22ae9260
commit 230bea5e58
2 changed files with 8 additions and 10 deletions

View File

@ -3771,7 +3771,7 @@ ReductionCodegenInfo IrEmitterUnnested::ComputeReductionCodegenInfo(
reduction_dimensions.is_row_reduction);
}
Status IrEmitterUnnested::EmitIRForReduction(
void IrEmitterUnnested::EmitIRForReduction(
HloInstruction* unnested_hlo,
absl::Span<HloInstruction* const> output_instructions,
ReductionCodegenInfo* reduction_info, const Shape& input_shape) {
@ -3820,8 +3820,6 @@ Status IrEmitterUnnested::EmitIRForReduction(
EmitEpilogueForReduction(index_ty, unnested_hlo, *reduction_info,
reduce_instructions, reduction_output_shape_indices,
reducers, tiling_kernel_info);
return Status::OK();
}
namespace {
@ -3830,9 +3828,9 @@ namespace {
// broadcasted constant/scalar.
bool IsBroadcastedConstantOrScalar(const HloInstruction& instr) {
return instr.IsConstant() || ShapeUtil::IsScalar(instr.shape()) ||
HloOpcode::kBroadcast == instr.opcode() &&
(instr.operand(0)->IsConstant() ||
ShapeUtil::IsScalar(instr.operand(0)->shape()));
(HloOpcode::kBroadcast == instr.opcode() &&
(instr.operand(0)->IsConstant() ||
ShapeUtil::IsScalar(instr.operand(0)->shape())));
}
// Divides output_instructions into groups. Different groups will be executed

View File

@ -530,10 +530,10 @@ class IrEmitterUnnested : public IrEmitter,
const TilingKernelInfo& tiling_kernel_info);
// Emits code for reductions in the output_instructions.
Status EmitIRForReduction(
HloInstruction* unnested_hlo,
absl::Span<HloInstruction* const> output_instructions,
ReductionCodegenInfo* reduction_info, const Shape& input_shape);
void EmitIRForReduction(HloInstruction* unnested_hlo,
absl::Span<HloInstruction* const> output_instructions,
ReductionCodegenInfo* reduction_info,
const Shape& input_shape);
// For each reducer, emits the shuffle-down loop to accumulate the partial
// result to the global result.