experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[NFC] Adopt FuncOp::isPublic() and friends

Browse Source 
PiperOrigin-RevId: 317335755
Change-Id: I6f1b25798150bb3a255d4572831d3be4747d28c7
This commit is contained in:
Rahul Joshi 2020-06-19 10:42:32 -07:00 committed by TensorFlower Gardener
parent fbf407383c
commit 1332b9365e
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tensorflow/compiler/mlir/tensorflow/ir/tf_saved_model.cc
View File

@ -231,12 +231,12 @@ static LogicalResult VerifySavedModelModule(
for (auto func : module.getOps<FuncOp>()) {
const bool is_exported = IsExported(func);
if (is_exported && func.getVisibility() != FuncOp::Visibility::Public) {
if (is_exported && !func.isPublic()) {
return func.emitError()
<< "exported function @" << func.getName() << " should be public";
}
if (!is_exported && func.getVisibility() == FuncOp::Visibility::Public) {
if (!is_exported && func.isPublic()) {
return func.emitError() << "non-exported function @" << func.getName()
<< " should be private";
}

2
tensorflow/compiler/mlir/tensorflow/transforms/stack_ops_decomposition.cc
View File

@ -343,7 +343,7 @@ LogicalResult HandlePartitionedCallOp(
}
llvm::SmallDenseMap<Value, Value> callee_map;
FuncOp lowered_callee = callee;
if (callee.getVisibility() != SymbolTable::Visibility::Private) {
if (!callee.isPrivate()) {
// Clone non-private callee in case of signature change.
lowered_callee = callee.clone();
lowered_callee.setVisibility(SymbolTable::Visibility::Private);

2
tensorflow/compiler/mlir/tensorflow/transforms/tensor_array_ops_decomposition.cc
View File

@ -759,7 +759,7 @@ LogicalResult HandlePartitionedCallOp(
return it->getSecond().accumulate_on_write;
};
FuncOp lowered_callee = callee;
if (callee.getVisibility() != SymbolTable::Visibility::Private) {
if (!callee.isPrivate()) {
// Clone non-private callee in case of signature change.
lowered_callee = callee.clone();
lowered_callee.setVisibility(SymbolTable::Visibility::Private);

2
tensorflow/compiler/mlir/tensorflow/transforms/tensor_list_ops_decomposition.cc
View File

@ -322,7 +322,7 @@ LogicalResult HandlePartitionedCallOp(
// Rewrite the callee.
llvm::SmallDenseMap<Value, SizeInfo> callee_map;
FuncOp lowered_callee = callee;
if (callee.getVisibility() != SymbolTable::Visibility::Private) {
if (!callee.isPrivate()) {
// Clone non-private callee in case of signature change.
lowered_callee = callee.clone();
lowered_callee.setVisibility(SymbolTable::Visibility::Private);