experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Misc ClangTidy cleanups.

Browse Source 
PiperOrigin-RevId: 317705032
Change-Id: I94c55b6d083c97f9962567ee28c2e952958a5ea8
This commit is contained in:
Yi Situ 2020-06-22 12:02:30 -07:00 committed by TensorFlower Gardener
parent 4a340a291f
commit 0a946a0069
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tensorflow/core/profiler/internal/gpu/cupti_tracer.cc
View File

@ -18,6 +18,7 @@ limitations under the License.
#include "absl/container/flat_hash_map.h"
#include "absl/container/flat_hash_set.h"
#include "absl/container/node_hash_map.h"
#include "absl/container/node_hash_set.h"
#include "tensorflow/core/platform/env.h"
#include "tensorflow/core/platform/errors.h"
#include "tensorflow/core/platform/host_info.h"
@ -683,7 +684,7 @@ Status CreateAndRecordEvent(CUevent *event, CUstream stream) {
// Note: cuStreamGetCtx only available after CUDA 9.2.
class ScopedCudaContext {
public:
ScopedCudaContext(CUstream stream) : stream_(stream) {
explicit ScopedCudaContext(CUstream stream) : stream_(stream) {
CuptiApiTracingDisabler disabler; // don't trace cuda call in this func.
CUcontext context;
if (cuStreamGetCtx(stream, &context) != CUDA_SUCCESS) return;
@ -1244,7 +1245,7 @@ class CuptiDriverApiHookWithCudaEvent : public CuptiDriverApiHook {
// However there is no guarantee that we receive such callbacks in pairs, we
// maintain a on-going API calls to make sure no memory leaks.
struct CuptiApiCallbackContext {
CuptiApiCallbackContext(std::vector<uint32> &&r)
explicit CuptiApiCallbackContext(std::vector<uint32> &&r)
: record_indices(std::move(r)) {}
std::vector<uint32> record_indices;
};
@ -1252,7 +1253,7 @@ class CuptiDriverApiHookWithCudaEvent : public CuptiDriverApiHook {
const CuptiTracerOptions option_;
CuptiInterface *cupti_interface_;
CuptiTraceCollector *collector_;
std::set<CuptiApiCallbackContext *> callback_contexts_;
absl::node_hash_set<CuptiApiCallbackContext *> callback_contexts_;
std::vector<std::unique_ptr<CudaEventRecorder>> cuda_event_recorders_;
TF_DISALLOW_COPY_AND_ASSIGN(CuptiDriverApiHookWithCudaEvent);
};

2
tensorflow/core/profiler/internal/gpu/device_tracer.cc
View File

@ -241,7 +241,7 @@ class CuptiTraceCollectorImpl : public CuptiTraceCollector {
std::string ReportDroppedEvents() {
absl::MutexLock lock(&mutex_);
string result;
for (const auto dropped : dropped_events_) {
for (const auto& dropped : dropped_events_) {
absl::StrAppend(&result, " ", dropped.second, " events dropped because ",
dropped.first, ";");
}