experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Do 2 warmup runs in assert_no_new_pyobjects_executing_eagerly.

Browse Source 
PiperOrigin-RevId: 215944829
This commit is contained in:
Todd Wang 2018-10-05 12:09:01 -07:00 committed by TensorFlower Gardener
parent 03b4161326
commit 0541a277d5
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tensorflow/python/framework/test_util.py
View File

@ -506,9 +506,9 @@ def disable_control_flow_v2(unused_msg):
def assert_no_new_pyobjects_executing_eagerly(f): def assert_no_new_pyobjects_executing_eagerly(f):
"""Decorator for asserting that no new Python objects persist after a test. """Decorator for asserting that no new Python objects persist after a test.
Runs the test multiple times executing eagerly, first as a warmup and then Runs the test multiple times executing eagerly, first as a warmup and then to
several times to let objects accumulate. The warmup helps ignore caches which let objects accumulate. The warmup helps ignore caches which do not grow as
do not grow as the test is run repeatedly. the test is run repeatedly.
Useful for checking that there are no missing Py_DECREFs in the C exercised by Useful for checking that there are no missing Py_DECREFs in the C exercised by
a bit of Python. a bit of Python.
@ -518,7 +518,14 @@ def assert_no_new_pyobjects_executing_eagerly(f):
"""Warms up, gets an object count, runs the test, checks for new objects.""" """Warms up, gets an object count, runs the test, checks for new objects."""
with context.eager_mode(): with context.eager_mode():
gc.disable() gc.disable()
f(self, **kwargs) # Run the test 2 times as warmup, in an attempt to fill up caches, which
# should not grow as the test is run repeatedly below.
#
# TODO(b/117156879): Running warmup twice is black magic; we have seen
# tests that fail with 1 warmup run, and pass with 2, on various versions
# of python2.7.x.
for _ in range(2):
f(self, **kwargs)
gc.collect() gc.collect()
previous_count = len(gc.get_objects()) previous_count = len(gc.get_objects())
if ops.has_default_graph(): if ops.has_default_graph():