diff --git a/tensorflow/compiler/mlir/hlo/README.md b/tensorflow/compiler/mlir/hlo/README.md index 9eaa14031fd..61517cd9fca 100644 --- a/tensorflow/compiler/mlir/hlo/README.md +++ b/tensorflow/compiler/mlir/hlo/README.md @@ -106,7 +106,7 @@ pipeline using MLIR: * `mhlo`: "meta"-HLO dialect ; similar to `xla_hlo`, but with extensions for dynamic shape support. * `lmhlo`: "late"-"meta"-HLO, it is the IR after buffer allocation is - performed. In XLA the buffer allocation is a side-datastructure which keeps + performed. In XLA the buffer allocation is a side-data structure which keeps track of these informations, while this separate dialect materializes it in the IR. @@ -114,7 +114,7 @@ We describe these in more details below. ### HLO Client Dialect: `chlo`. -* It was originaly designed to map the +* It was originally designed to map the [XLA client APIs](https://www.tensorflow.org/xla/operation_semantics) (e.g., ops supports implicit broadcast and roughly modeled on XlaBuilder API) modulo support for dynamic shapes and additional ops required to support diff --git a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/lhlo_ops.td b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/lhlo_ops.td index 6e6af2065fc..37757fa0033 100644 --- a/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/lhlo_ops.td +++ b/tensorflow/compiler/mlir/hlo/include/mlir-hlo/Dialect/mhlo/IR/lhlo_ops.td @@ -16,19 +16,19 @@ limitations under the License. // This is the operation definition file for LMHLO, the "late" MHLO variant of // the dialect, which operates on buffers instead of tensors. // -// This file largely overlaps with mhlo_ops.td at a logic level. It's tempting to -// merge these two files together, but we need to consider the following +// This file largely overlaps with hlo_ops.td at a logical level. It's tempting +// to merge these two files together, but we need to consider the following // obstacles: // * We need to have a common representation for arguments. That is to say, -// HLO_Array translates to HLO_Tensor in HLO dialect, and -// Arg, "", [Mem(Read|Write)]> in LHLO. Array types within tuples -// also need to be transformed. +// HLO_Array translates to HLO_Tensor in HLO dialect, and +// Arg, "", [Mem(Read|Write)]> in LHLO. Array types within +// tuples also need to be transformed. // * As of now, TableGen's dag functions are not sufficient to accomplish the -// one above. -// * Traits aren't identical, but need to be coped. For example, -// SameOperandAndResultType in HLO corresponds to SameTypeOperands in LHLO. +// one above. +// * Traits aren't identical, but need to be copied. For example, +// SameOperandAndResultType in HLO corresponds to SameTypeOperands in LHLO. // * Also, currently HLO describes the API in XLA's client side, not service -// side. LHLO aims for the service side. +// side. LHLO aims for the service side. #ifndef LHLO_OPS #define LHLO_OPS